Skip to content

Fix: Fix import when column was adjusted in preview screen #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Koc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Fix import when column was adjusted in preview screen #2239

Koc wants to merge 1 commit into from

Conversation

@Koc
Copy link
Contributor

@Koc Koc commented Dec 28, 2025 •
edited
Loading

This PR fixes a bug. Here a reproducer:

  1. Create e table
  2. Start import xlsx file
  3. Before actual importing - adjust settings of the created column, e.g. change "single line" type to "multi line"
  4. Start importing

Expected result: file imported

Actual result: there is an error

Details 

Technical details

    Remote Address: 172.30.1.1
    Request ID: lu7YdLQLvAKMPV6mHYOD
    Type: Exception
    Code: 0
    Message: OCA\Tables\Dto\Column::__construct(): Argument #25 ($customSettings) must be of type ?string, array given, called in /var/www/html/apps/tables/lib/Dto/Column.php on line 46 in file '/var/www/html/apps/tables/lib/Dto/Column.php' line 11
    File: /var/www/html/lib/private/AppFramework/Http/Dispatcher.php
    Line: 150


Trace

#0 /var/www/html/lib/private/AppFramework/App.php(153): OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\Tables\Controller\ImportController), 'importUploadInT...')
#1 /var/www/html/lib/private/Route/Router.php(321): OC\AppFramework\App::main('OCA\\Tables\\Cont...', 'importUploadInT...', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)
#2 /var/www/html/lib/base.php(1061): OC\Route\Router->match('/apps/tables/im...')
#3 /var/www/html/index.php(25): OC::handleRequest()
#4 {main}


Previous

#0 /var/www/html/apps/tables/lib/Dto/Column.php(46): OCA\Tables\Dto\Column->__construct('Notes', 'text', 'long', false, 'This column was...', '', NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL, Array)
#1 /var/www/html/apps/tables/lib/Service/ImportService.php(584): OCA\Tables\Dto\Column::createFromArray(Array)
#2 /var/www/html/apps/tables/lib/Service/ImportService.php(356): OCA\Tables\Service\ImportService->getColumns(Object(OCA\Tables\Vendor\PhpOffice\PhpSpreadsheet\Worksheet\Row), Object(OCA\Tables\Vendor\PhpOffice\PhpSpreadsheet\Worksheet\Row))
#3 /var/www/html/apps/tables/lib/Service/ImportService.php(315): OCA\Tables\Service\ImportService->loop(Object(OCA\Tables\Vendor\PhpOffice\PhpSpreadsheet\Worksheet\Worksheet))
#4 /var/www/html/apps/tables/lib/Controller/ImportController.php(118): OCA\Tables\Service\ImportService->import(36, NULL, '/tmp/php4PehuD', true, Array)
#5 /var/www/html/apps/tables/lib/Controller/Errors.php(23): OCA\Tables\Controller\ImportController->OCA\Tables\Controller\{closure}()
#6 /var/www/html/apps/tables/lib/Controller/ImportController.php(116): OCA\Tables\Controller\ImportController->handleError(Object(Closure))
#7 /var/www/html/lib/private/AppFramework/Http/Dispatcher.php(204): OCA\Tables\Controller\ImportController->importUploadInTable(36, true, '[{"titleRaw":"F...')
#8 /var/www/html/lib/private/AppFramework/Http/Dispatcher.php(118): OC\AppFramework\Http\Dispatcher->executeController(Object(OCA\Tables\Controller\ImportController), 'importUploadInT...')
#9 /var/www/html/lib/private/AppFramework/App.php(153): OC\AppFramework\Http\Dispatcher->dispatch(Object(OCA\Tables\Controller\ImportController), 'importUploadInT...')
#10 /var/www/html/lib/private/Route/Router.php(321): OC\AppFramework\App::main('OCA\\Tables\\Cont...', 'importUploadInT...', Object(OC\AppFramework\DependencyInjection\DIContainer), Array)
#11 /var/www/html/lib/base.php(1061): OC\Route\Router->match('/apps/tables/im...')
#12 /var/www/html/index.php(25): OC::handleRequest()
#13 {main}

This happens because FE send to BE "customSettings": {}, for adjusted columns

@Koc Koc requested review from blizzz and enjeck as code owners December 28, 2025 13:36
@Koc Koc added the bug Something isn't working label Jan 4, 2026
@Koc Koc force-pushed the bugfix/fix-import branch 2 times, most recently from e9f358c to 8bbdd1c Compare January 10, 2026 20:40
@Koc Koc requested a review from juliusknorr January 10, 2026 20:43
@Koc Koc force-pushed the bugfix/fix-import branch 2 times, most recently from 1d0e96c to ab0a113 Compare January 12, 2026 11:49
@enjeck enjeck force-pushed the bugfix/fix-import branch 2 times, most recently from 726ec4e to 160a502 Compare January 13, 2026 04:42
@enjeck
Copy link
Contributor

enjeck commented Jan 13, 2026

/backport to stable1.0

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jan 13, 2026
@Koc Koc force-pushed the bugfix/fix-import branch from 160a502 to 1ad619c Compare January 13, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enjeck enjeck Awaiting requested review from enjeck enjeck is a code owner

@blizzz blizzz Awaiting requested review from blizzz blizzz is a code owner

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

backport-request Pending backport by the backport-bot bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Koc @enjeck